[PATCH] D88468: [llvm-readobj] Fix error when printing out stabs symbols of type N_OSO

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 11:58:20 PDT 2020


int3 marked 3 inline comments as done.
int3 added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/MachO/Inputs/stabs.obj.macho-x86_64.yaml:250
+    - ''
+...
----------------
grimar wrote:
> I am not an expert in MachO, but It feels that this YAML contains excessive symbols, sections, strings etc.
> The best practice is to have tests as little as possible to improve readability. Can this one be reduced?
it's a bit of a pain to reduce yaml by hand. A lot of the extra symbols are things that get inserted into a trivial Mach-O binary by clang and/or the linker. I've removed a bunch of extra load commands but left the symbols as-is (symbols are harder to remove)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88468/new/

https://reviews.llvm.org/D88468



More information about the llvm-commits mailing list