[PATCH] D88455: [NFC][regalloc] Unit test for AllocationOrder iteration.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi @mtrofin,

Thanks for doing this.

LGTM with one comment.

Cheers,
-Quentin



================
Comment at: llvm/lib/CodeGen/AllocationOrder.h:46
+                                const RegisterClassInfo &RegClassInfo,
+                                const LiveRegMatrix *Matrix);
+
----------------
What's the rationale for turning this constructor into a static method?


================
Comment at: llvm/unittests/CodeGen/AllocationOrderTest.cpp:115
+}
\ No newline at end of file

----------------
Please add a new line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88455/new/

https://reviews.llvm.org/D88455