[PATCH] D88406: [LiveDebugValues][InstrRef][2/2] Emit entry value variable locations

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks a lot for such a nice explanation! I've got it (at least for this example)!

The entry value work should be "simple" as well as more effective with this approach. Some initial comments inline.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:3116
+      // transfers after them.
+      if (P.Pos->isTerminator())
+        continue;
----------------
Should this be a separate patch? Does this affect/apply to the "copies" as backups?


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_load_in_loop.mir:83
     $rbp = MOV64rr $rdi, debug-location !17
+    DBG_VALUE $rbp, $noreg, !16, !DIExpression(), debug-location !17
     dead $rcx = MOV64ri 0, debug-location !17
----------------
Why including this here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88406/new/

https://reviews.llvm.org/D88406