[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:198
+    LLVM_DEBUG(dbgs() << "Loop is not invariant or is not required to make "
+                         "progress, cannot delete.\n");
     return Changed ? LoopDeletionResult::Modified
----------------
not accurate anymore, just go back to the old version, also in the comment above.


================
Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:209
+    LLVM_DEBUG(dbgs() << "Could not compute SCEV MaxBackedgeTakenCount or was "
+                         "not required to make progress.\n");
     return Changed ? LoopDeletionResult::Modified
----------------
-or +and


================
Comment at: llvm/test/Transforms/LoopDeletion/mustprogress.ll:19
+; CHECK:       for.cond1:
+; CHECK-NEXT:    br label [[FOR_COND1]]
+;
----------------
why is the loop not deleted?


================
Comment at: llvm/test/Transforms/LoopDeletion/mustprogress.ll:50
+; CHECK:       for.cond1:
+; CHECK-NEXT:    br label [[FOR_COND1]]
+;
----------------
same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86844/new/

https://reviews.llvm.org/D86844