[PATCH] D88487: [TableGen][GlobalISel] add handling of nested *_SUBREG

[Gabriel Hjort Åkerlund via Phabricator via llvm-commits]

ehjogab added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4954
   }
+  else if (InstName == "INSERT_SUBREG") {
+    TreePatternNode *Child0 = N->getChild(0);
----------------
arsenm wrote:
> No else after return
In the original code, there is only an 'if' and no 'else', so I followed the same original structure by just adding the 'else if's. I believe the 'else' case is handled by the code that follow these if statements.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4960
+  }
+  else if (InstName == "EXTRACT_SUBREG") {
+    assert(N->getNumTypes() == 1 && "Unexpected number of types!");
----------------
arsenm wrote:
> No else after return
Same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88487/new/

https://reviews.llvm.org/D88487