[PATCH] D88485: [SDag][AMDGPU] Maintain DAG divergence through instruction selection
Madhur Amilkanthwar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 29 07:42:50 PDT 2020
madhur13490 added a comment.
I think this is useful to have until we completely switch to GlobalISel. I agree with any new effort being low !/$ but since you have made it, I'd vote to get this in.
BTW, I think we can have lit tests to verify this. Dump DAG before and after isel and check with file-check. I am not sure if just dumping with existing dump() routine would dump all the required information but its worthwhile to have a test, IMHO.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88485/new/
https://reviews.llvm.org/D88485
More information about the llvm-commits
mailing list