[PATCH] D88487: [TableGen][GlobalISel] add handling of nested *_SUBREG

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelEmitter-nested-subregs.td:33
+
+def : Pat<(i16 (anyext i8:$src)),
+          (i16 (EXTRACT_SUBREG
----------------
This is missing the checks?


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4954
   }
+  else if (InstName == "INSERT_SUBREG") {
+    TreePatternNode *Child0 = N->getChild(0);
----------------
No else after return


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4960
+  }
+  else if (InstName == "EXTRACT_SUBREG") {
+    assert(N->getNumTypes() == 1 && "Unexpected number of types!");
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88487/new/

https://reviews.llvm.org/D88487