[PATCH] D88288: [Archive] Don't throw away errors for malformed archive members

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 05:57:54 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/SymbolicFile.cpp:47-48
+
   switch (Type) {
   case file_magic::bitcode:
     if (Context)
----------------
rupprecht wrote:
> I'm still seeing `-Wswitch` errors:
> 
> ```
> /home/rupprecht/src/llvm-project/llvm/lib/Object/SymbolicFile.cpp:47:11: warning: 8 enumeration values not handled in switch: 'unknown', 'archive', 'macho_universal_binary'... [-Wswitch]
>   switch (Type) {
> ```
Oops, sorry. Forgot to add the necessary `default` label.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88288/new/

https://reviews.llvm.org/D88288



More information about the llvm-commits mailing list