[PATCH] D88274: [PowerPC] Put the CR field in low bits of GRC during copying CRRC to GRC.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 05:17:35 PDT 2020


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. The code here is correct, but I do have a couple of questions:

1. Do these copies come up in real code? And if so, under which circumstances. We don't have copies in the other direction implemented, so that makes me wonder when these ever come up.
2. Does this solve a problem seen in real code? If so, is there a bugzilla report? At the very least, the conditions under which this causes a problem should be added to the description.
3. Is there any follow up required/planned for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88274/new/

https://reviews.llvm.org/D88274



More information about the llvm-commits mailing list