[PATCH] D87494: Improve LSR debug-info

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope accepted this revision.
bjope added a comment.

One more nit related to making computeConstantDifference public , but I'm happy with the fixup related to making the test case more target-agnostic.



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:1779
   /// to be a constant.
+public:
   Optional<APInt> computeConstantDifference(const SCEV *LHS, const SCEV *RHS);
----------------
nit: Probably cleaner to move this declaration up into the public section, now when it is made available in the public API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87494/new/

https://reviews.llvm.org/D87494