[PATCH] D88475: [InstCombine] visitTrunc - trunc (lshr (sext A), C) --> (ashr A, C) non-uniform support

Tue Sep 29 04:25:26 PDT 2020

lebedev.ri added a comment.

In D88475#2300263 <https://reviews.llvm.org/D88475#2300263>, @RKSimon wrote:

> In D88475#2300260 <https://reviews.llvm.org/D88475#2300260>, @lebedev.ri wrote:
>
>> Hm, why do we need that clamping here?
>> If it's for `undef`s, see `Constant::replaceUndefsWith()`.
>
> Isn't it matching the existing std::min calls ?

Yes, obviously. I'm asking why it's there in the first place.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88475/new/

https://reviews.llvm.org/D88475