[PATCH] D88401: [lib/Support/CommandLine][windows] - Handle "\ " as a space token.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 29 00:59:30 PDT 2020
grimar added a comment.
Thanks, Reid, I guess you're right. I've posted a comment on the bug page.
In D88401#2300007 <https://reviews.llvm.org/D88401#2300007>, @jhenderson wrote:
> If we switch to a GNU style tokenisation, I'd like to know the difference in behaviour versus the Windows one, since our existing user base will be used to the Windows version. That being said, since LLD is supposed to be GNU compatible, it would make sense if it matched the GNU behaviour.
I believe that windows tokenizer implements this:
https://docs.microsoft.com/en-us/previous-versions//17w5ykft(v=vs.85)?redirectedfrom=MSDN
I don't have a text description for GNU tokenizer, but it's implementation looks simple and straightforward. See `cl::TokenizeGNUCommandLine` (https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/CommandLine.cpp#L827).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88401/new/
https://reviews.llvm.org/D88401
More information about the llvm-commits
mailing list