[PATCH] D87828: [SCEV][NFC] Introduce isBasicBlockEntryGuardedByCond

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:682
+  /// between LHS
+  /// and RHS.
+  bool isBasicBlockEntryGuardedByCond(const BasicBlock *BB,
----------------
nit: move to previous line?


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:9455
+bool ScalarEvolution::isBasicBlockEntryGuardedByCond(const BasicBlock *BB,
+                                                     ICmpInst::Predicate Pred,
+                                                     const SCEV *LHS,
----------------
mkazantsev wrote:
> mkazantsev wrote:
> > fhahn wrote:
> > > tab?
> > Eeek! It was supposed to be clang-formated... 
> I'm not sure what it is, it's all whitespaces in my diff file. Display bug of phabricator?
Possibly :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87828/new/

https://reviews.llvm.org/D87828