[PATCH] D87832: [IndVars] Remove monotonic checks with unknown exit count

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:923
+  bool isKnownPredicateAt(ICmpInst::Predicate Pred, const SCEV *LHS,
+                        const SCEV *RHS, const BasicBlock *BB);
+
----------------
reames wrote:
> For the context, use an instruction even if you don't actually need it yet.  We made this mistake in LVI and spent years digging out.  The problem with using the BB is you have to be very careful in documenting where in said block the fact holds.  
Just curious: what kind of mistake it was?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87832/new/

https://reviews.llvm.org/D87832