[PATCH] D88337: [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 28 16:52:04 PDT 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/test/tools/llvm-ml/radix_errors.test:1
+; RUN: not llvm-ml -filetype=asm %s 2>&1 | FileCheck %s
+
----------------
Maybe add `--implicit-check-not=error:` to catch other errors between the expected errors.
================
Comment at: llvm/test/tools/llvm-ml/radix_errors.test:13
+
+; CHECK: error: invalid decimal number
+; CHECK: error: invalid binary number
----------------
You could use the `[[@LINE+1]]` filecheck feature to tighten these up, but I think it's fine as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88337/new/
https://reviews.llvm.org/D88337
More information about the llvm-commits
mailing list