[PATCH] D88423: Fix llvm-link assert failure in BitCodeWriter

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Bitcode/Writer/ValueEnumerator.cpp:410
+
+      if (A.hasAttribute(Attribute::StructRet))
+        EnumerateType(A.getParamStructRetType());
----------------
This would also be a problem for preallocated (but I think inalloca is still missing the type)


================
Comment at: llvm/lib/Bitcode/Writer/ValueEnumerator.cpp:974-975
     EnumerateValue(&I);
-    if (I.hasAttribute(Attribute::ByVal))
-      EnumerateType(I.getParamByValType());
   }
----------------
Why does this move?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88423/new/

https://reviews.llvm.org/D88423