[PATCH] D87811: [CodeGen] emit CG profile for COFF object file

[Zequan Wu via Phabricator via llvm-commits]

zequanwu added inline comments.


================
Comment at: llvm/lib/MC/MCWinCOFFStreamer.cpp:344
   if (Created) {
-    cast<MCSymbolCOFF>(S)->setIsWeakExternal();
     cast<MCSymbolCOFF>(S)->setExternal(true);
   }
----------------
It's meaningless to set symbol to WeakExternal and External at same time here. At the end, the symbol just become WeakExternal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87811/new/

https://reviews.llvm.org/D87811