[PATCH] D86142: [LLD] Search archives for non-tentative defintions.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.h:318
+  // If the symbol is either a strong or weak definition, we fetch.
+  bool shouldFetchForCommon(const StringRef &Name);
+
----------------
`name`


================
Comment at: lld/ELF/Symbols.cpp:713
+    if (auto *loSym = dyn_cast<LazyObject>(&other)) {
+      LazyObjFile *obj = dyn_cast<LazyObjFile>(loSym->file);
+      if (obj->shouldFetchForCommon(loSym->getName())) {
----------------
dyn_cast -> cast ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86142/new/

https://reviews.llvm.org/D86142