[PATCH] D88422: [GlobalISel] fix widenScalarUnmerge if widen type is not a multiple of destination type

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1652
+
+    SmallVector<Register, 4> RemergeParts;
+    for (int I = 0; I != NumDst; ++I) {
----------------
Maybe 8?


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1655
+      for (int J = 0; J < PartsPerRemerge; ++J) {
+        const int Idx = J + I * PartsPerRemerge;
+        RemergeParts.emplace_back(Parts[Idx]);
----------------
+ J at the end?


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:3138
 
+// Test fewer elements of G_INSERT_VECTOR_ELEMENT
+TEST_F(AArch64GISelMITest, widenScalarUnmerge) {
----------------
Comment is wrong


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88422/new/

https://reviews.llvm.org/D88422