[PATCH] D88371: Introduce a LLVM_ENABLE_TENSORFLOW CMake option for users to opt-in instead of silently trying to enable it
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 28 13:46:01 PDT 2020
mehdi_amini added a comment.
In D88371#2298235 <https://reviews.llvm.org/D88371#2298235>, @mtrofin wrote:
> There are 2 types of TF dependencies, orthogonal from each other, controlled by TENSORFLOW_AOT_PATH and TENSORFLOW_C_LIB_PATH, respectively.
>
> The former should already provide the desired behavior.
Right!
> The latter is the problem, due to `find_library` behavior (line 840 old code): I think it's missing a NO_DEFAULT_PATH, which should then result in the desired behavior.
I don't think we should invoke find_library without an opt-in from the user, this is what this patch is addressing here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88371/new/
https://reviews.llvm.org/D88371
More information about the llvm-commits
mailing list