[PATCH] D88305: [COFF] Aliases resolve directly to defined external targets

Mon Sep 28 12:58:10 PDT 2020

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM

Awesome, thanks for finding all the relevant cases here. I've tested it with my own testsuite for GNU style weak symbols, and it seems to still be working.

================
Comment at: llvm/test/MC/COFF/weak-alias-labels.s:87
+    .weak t4
+t4 = bar
+
----------------
Out of curiosity - how does the t4 case differ from t1? Only in the fact that bar is defined further ahead in the file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88305/new/

https://reviews.llvm.org/D88305