[PATCH] D88407: [llvm-readobj/elf] - Fix the PREL31 relocation computation used for dumping arm32 unwind info (-u).

Mon Sep 28 11:46:48 PDT 2020

MaskRay added a comment.

LGTM

In D88407#2298019 <https://reviews.llvm.org/D88407#2298019>, @grimar wrote:

> In D88407#2297935 <https://reviews.llvm.org/D88407#2297935>, @psmith wrote:
>
>> LGTM. Agree that it should be bit31 that is sign extended. Apologies for not catching this last time.
>
> No worries. This and few other issues are/were mentioned in comments on the bug page. They are about 6 years old,
> I guess nobody tried to heavily use "llvm-readobj -u" before. I am going to try to fix all of them. Thanks for quick review!

Thanks for fixing this! I tend to agree with `nobody tried to heavily use "llvm-readobj -u" before` (not nobody but definitely not many)..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88407/new/

https://reviews.llvm.org/D88407