[PATCH] D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM for the narrow fix as written + pointing out a nearby bug.

A broader fix is worth discussing, but no reason to hold back a local fix.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:474
 
   for (auto *EVI : ToDelete)
     EVI->eraseFromParent();
----------------
JFYI, as a separate issue, this logic shouldn't be here.  We should be adding the empty extracts to the DeadInst set instead and deferring deletion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85971/new/

https://reviews.llvm.org/D85971