[PATCH] D88423: Fix llvm-link assert failure in BitCodeWriter

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I'm not sure I understand the reason behind moving the EnumerateType call from incorporateFunction to the ValueEnumerator constructor.  We don't walk the attributes before that, do we?



================
Comment at: llvm/lib/Bitcode/Writer/ValueEnumerator.cpp:408
+      if (A.hasAttribute(Attribute::ByVal))
+        EnumerateType(A.getParamByValType());
+
----------------
getPointeeInMemoryValueType()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88423/new/

https://reviews.llvm.org/D88423