[PATCH] D83635: [OpenMPOpt][WIP] Merge parallel regions

Giorgis Georgakoudis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 10:26:03 PDT 2020


ggeorgakoudis marked 3 inline comments as done.
ggeorgakoudis added inline comments.


================
Comment at: llvm/test/Transforms/OpenMP/parallel_region_merging.ll:318
+!0 = !{!1}
+!1 = !{i64 2, i64 -1, i64 -1, i1 true}
----------------
ggeorgakoudis wrote:
> jdoerfert wrote:
> > sstefan1 wrote:
> > > jdoerfert wrote:
> > > > The update test script cannot add check lines for new functions yet. Can you manually add some minimal check lines to ensure the new function we create looks as expected, e.g., has regular calls to the former parallel regions?
> > > Maybe I can take a look at that since I'm now somewhat familiar with the script.
> > there is a patch for the _cc_ script already: D83004. I suggested there to make it generic (common.py) for _cc_ and the opt script, maybe we can do it in 2 steps instead. < @greened 
> I see the patch is accepted but not yet committed. Waiting for it to be upstreamed.
Use the new version of the script that includes generated functions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83635/new/

https://reviews.llvm.org/D83635



More information about the llvm-commits mailing list