[PATCH] D88232: [DebugInfo] Handle multiple variable location operands in IR

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 10:01:35 PDT 2020


StephenTozer added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1277
+      for (auto &Inst : BB) {
+        if (auto *DVI = dyn_cast<DbgVariableIntrinsic>(&Inst)) {
+          for (Value *V : DVI->getVariableLocationOps()) {
----------------
aprantl wrote:
> nit: remove redundant {}?
The braces in this case are following the [[ https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements | coding standards ]], specifically following the examples "Use braces for the outer `if` since the nested `for` is braced" and "Use braces on the outer block because there are more than two levels of nesting."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88232/new/

https://reviews.llvm.org/D88232



More information about the llvm-commits mailing list