[PATCH] D88166: [SCEV] Verify that all mapped SCEV AddRecs refer to valid loops.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 09:36:33 PDT 2020


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

A cleaner way to handle this check would be to enumerate all loops in LoopInfo, and then check that the loop of every AR is in that set.  I the loop has already been deleted, dereferencing it to check the valid flags seems a bit suspect.

Actually, why not just implement the isInvalid check on Loop that way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88166/new/

https://reviews.llvm.org/D88166



More information about the llvm-commits mailing list