[PATCH] D88230: [DebugInfo] Support multiple location operands via DIArgList in DbgVariableIntrinsics
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 28 09:06:57 PDT 2020
aprantl added inline comments.
================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:46
+ if (AllowNullOp && !Op) {
+ Result.push_back(nullptr);
+ return Result;
----------------
Maybe this isn't such a big deal, but this function has a weird UI now — returning a SmallVector with nullptrs... I wonder if we should instead return a small iterator object? How is this used?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88230/new/
https://reviews.llvm.org/D88230
More information about the llvm-commits
mailing list