[PATCH] D88418: [RDA] Add def checks to isSafeToRemove

[Sam Parker via Phabricator via llvm-commits]

samparker created this revision.
samparker added reviewers: SjoerdMeijer, samtebbs, nikic, dmgreen.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: LLVM.
samparker requested review of this revision.

We were tracking a use chain from a def, but we weren't considering any register defs that weren't a part of the chain. This could result in the program being changed incorrectly. This has resulted in a few ARMLowOverheadLoop test changes around the loop iteration copies because that has also been changed to more accurately query the safety of removing LoopDec.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88418

Files:
  llvm/lib/CodeGen/ReachingDefAnalysis.cpp
  llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/end-positive-offset.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/loop-dec-copy-chain.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/loop-dec-copy-prev-iteration.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/loop-dec-liveout.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/predicated-invariant.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/remove-elem-moves.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/safe-retaining.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/unsafe-cpsr-loop-use.mir
  llvm/test/CodeGen/Thumb2/mve-satmul-loops.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88418.294698.patch
Type: text/x-patch
Size: 24809 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200928/5733a743/attachment.bin>