[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

Mon Sep 28 01:30:32 PDT 2020

jhenderson added a comment.

In D88199#2295596 <https://reviews.llvm.org/D88199#2295596>, @MaskRay wrote:

> In D88199#2292193 <https://reviews.llvm.org/D88199#2292193>, @jhenderson wrote:
>
>> Mostly looks okay. I think there is no testing for the assembly parser being able to parse the new section type?
>>
>> I'm also keen to hear what others think (e.g. @MaskRay).
>
>
>
>> This patch lets the bb_addr_map (renamed to llvm_bb_addr_map) section use a special section type (SHT_LLVM_BB_ADDR_MAP) instead of SHT_PROGBITS. This would help linker and other tools to use the sh_type ELF field to identify this section rather than relying on string comparison on the section name.
>
> This description implies that some special processing is needed in the linker. (As you can see, when llvm_call_graph_profile and llvm_dependent_libraries were proposed, they had clear patches on the linker side.)

Maybe pivot the statement to say "dumpers and other tools"? Dumpers will need to know the section type for simpler processing of the code, even if the linker has no special handling currently.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88199/new/

https://reviews.llvm.org/D88199