[PATCH] D87978: [WIP][Attributor] Adds deduction for the MaxObjSize Attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/maxobjsize.ll:189
+  %2 = call i8* @capture_realloc(i8* %1)
+  ret i8* %2
+}
----------------
duplicate the test so it exists 3 times. In this version we can actually add maxobjsize to the call site argument, we can do so as well if the use is not reachable from a capturing use. We don't need to add the logic but the test might be worth adding with a fixme.


================
Comment at: llvm/test/Transforms/Attributor/maxobjsize.ll:173
+  %1 = call i32** @capture(i32* %0)
+  %2 = call i32** @capture(i32* @G)
+  br i1 %a, label %if, label %else
----------------
add another use of %0 and @G here before the capture calls


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87978/new/

https://reviews.llvm.org/D87978