[PATCH] D88360: [ValueTracking] Fix analyses to update CxtI to be phi's incoming edges' terminators
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 27 18:34:01 PDT 2020
aqjune marked 2 inline comments as done.
aqjune added inline comments.
================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:789
+ EXPECT_EQ(isGuaranteedNotToBePoison(A), true)
+ << "isGuaranteedNotToBePoison does not hold at " << *TI;
+ }
----------------
nikic wrote:
> This test looks like it would be passing both before and after your change. You're also not passing TI to the function, so the failure message doesn't really make sense.
Sorry, my mistake. Fixed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88360/new/
https://reviews.llvm.org/D88360
More information about the llvm-commits
mailing list