[PATCH] D82703: [InstCombine] convert assumes to operand bundles

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added reviewers: spatel, lebedev.ri, xbolva00, efriedma, fhahn.
jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/assume.ll:255
+; BUNDLES-NEXT:    tail call void @escape(i32* nonnull [[LOAD]])
+; BUNDLES-NEXT:    ret i1 false
 ;
----------------
It is questionable if we should prefer the assume or the `!nonnull` metadata here.


================
Comment at: llvm/test/Transforms/InstCombine/assume.ll:710
+  ret void
+}
+
----------------
Also unclear if this is better than the GEP. I guess the case with an offset of 4 is clear but this one I don't know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82703/new/

https://reviews.llvm.org/D82703