[PATCH] D88353: [BasicAA] Integrate MaxObjSize for NoAlias

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

We need new tests specifically for this. Using the maxobjsize attribute especially



================
Comment at: llvm/lib/Analysis/BasicAliasAnalysis.cpp:263
+  return V.getPointerMaxObjSizeBytes(DL);
+}
+
----------------
Add a comment above `getPointerMaxObjSizeBytes` stating that this is an over-approximation of the "extend till the end". In fact it is multi kinds of over-approximation, one of which is that it is an over-approximation of the maximal extend of the object, regardless of the offset \p V has into it.


================
Comment at: llvm/test/Transforms/Attributor/readattrs.ll:158
   ret void
 }
 
----------------
We have to check if this is not unrelated. I'll run the update script on the attributor files again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88353/new/

https://reviews.llvm.org/D88353