[PATCH] D88365: Port ConstraintElimination to the new pass manager

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 26 21:17:44 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:611
 
+  if (EnableConstraintElimination)
+    FPM.addPass(ConstraintEliminationPass());
----------------
I add it here to emulate to legacy pass manager builder's behavior.

I wonder whether the intention is to move some stuff from CorrelatedValuePropagationPass to ConstraintEliminationPass. Does it make sense to place ConstraintEliminationPass before/after CorrelatedValuePropagationPass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88365/new/

https://reviews.llvm.org/D88365



More information about the llvm-commits mailing list