[PATCH] D88309: [LTO][Legacy] Add API to set result type to assembly

wael yehia via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 26 00:19:39 PDT 2020


w2yehia added a comment.

Thanks Steven and Teresa.

> Also, passing LTO option through -mllvm option (aka, through commanline option flags) is not officially supported.

Not sure what you mean by " through -mllvm option". 
By the way, if you're using the GOLD plugin interface to invoke LTO, you just pass options thru -plugin-opt, no -mllvm. And in libLTO, you pass options through `lto_codegen_debug_options` C function.
Also, libLTO does query options defined in the LTO files (the function `lto_add_attrs` queries the `-mattr` option).

I'll take the new API approach then, unless there are objections from anyone else (shud we add more reviewers?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88309/new/

https://reviews.llvm.org/D88309



More information about the llvm-commits mailing list