[PATCH] D73739: Exception support for basic block sections

[Di Mo via Phabricator via llvm-commits]

modimo added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:485
 
   bool VerboseAsm = Asm->OutStreamer->isVerboseAsm();
 
----------------
rahmanl wrote:
> MaskRay wrote:
> > 
> This is existing code copied here. Does it matter that we make the boolean const since it's temporary and we can't take the address/reference of the temporary.
Perf and but more importantly read-ability that this is only calculated here. IMO a good thing to get in the habit of. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739