[PATCH] D88335: [BuildLibCalls] Add noalias for strcat and stpcpy

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 14:11:34 PDT 2020


efriedma added a comment.

If everyone is satisfied the noalias markings won't cause any practical issues, that's fine.

> noalias on its own is probably not too useful in this context, but I think without noalias, we cannot mark either argument as readonly/writeonly

That isn't how readonly works.  From LangRef: "On an argument, this attribute indicates that the function does not write through this pointer argument, even though it may write to the memory that the pointer points to."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88335/new/

https://reviews.llvm.org/D88335



More information about the llvm-commits mailing list