mclow.lists added a comment. I would rather see: llvm_unreachable("unexpected type"); return ""; // or string() i.e, keep the call to unreachable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87697/new/ https://reviews.llvm.org/D87697