[lld] 2c2a749 - [lld-macho] Ignore a few more undocumented flags

[Jez Ng via llvm-commits]

Author: Jez Ng
Date: 2020-09-25T11:28:37-07:00
New Revision: 2c2a7494482133ecdd681869e1ccc53b71d27385

URL: https://github.com/llvm/llvm-project/commit/2c2a7494482133ecdd681869e1ccc53b71d27385
DIFF: https://github.com/llvm/llvm-project/commit/2c2a7494482133ecdd681869e1ccc53b71d27385.diff

LOG: [lld-macho] Ignore a few more undocumented flags

Reviewed By: #lld-macho, compnerd

Differential Revision: https://reviews.llvm.org/D88268

Added: 
    

Modified: 
    lld/MachO/Options.td
    lld/test/MachO/silent-ignore.test

Removed: 
    


################################################################################
diff  --git a/lld/MachO/Options.td b/lld/MachO/Options.td
index ddcf8aa33864..353ef03455bf 100644
--- a/lld/MachO/Options.td
+++ b/lld/MachO/Options.td
@@ -188,6 +188,10 @@ def platform_version : MultiArg<["-"], "platform_version", 3>,
      MetaVarName<"<platform> <min_version> <sdk_version>">,
      HelpText<"Platform (e.g., macos, ios, tvos, watchos, bridgeos, mac-catalyst, ios-sim, tvos-sim, watchos-sim, driverkit) and version numbers">,
      Group<grp_opts>;
+def sdk_version : Separate<["-"], "sdk_version">,
+     HelpText<"This option is undocumented in ld64">,
+     Flags<[HelpHidden]>,
+     Group<grp_opts>;
 def macos_version_min : Separate<["-"], "macos_version_min">,
      MetaVarName<"<version>">,
      HelpText<"Oldest macOS version for which linked output is useable">,
@@ -204,6 +208,11 @@ def ios_version_min : Separate<["-"], "ios_version_min">,
      HelpText<"Oldest iOS version for which linked output is useable">,
      Flags<[HelpHidden]>,
      Group<grp_opts>;
+def ios_simulator_version_min : Separate<["-"], "ios_simulator_version_min">,
+     MetaVarName<"<version>">,
+     HelpText<"Oldest iOS simulator version for which linked output is useable">,
+     Flags<[HelpHidden]>,
+     Group<grp_opts>;
 def iphoneos_version_min : Separate<["-"], "iphoneos_version_min">,
      MetaVarName<"<version>">,
      Alias<ios_version_min>,
@@ -1212,7 +1221,7 @@ def no_new_main : Flag<["-"], "no_new_main">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
-def objc_abi_version : Flag<["-"], "objc_abi_version">,
+def objc_abi_version : Separate<["-"], "objc_abi_version">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
@@ -1228,10 +1237,6 @@ def save_temps : Flag<["-"], "save-temps">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,
      Group<grp_undocumented>;
-def sdk_version : Flag<["-"], "sdk_version">,
-     HelpText<"This option is undocumented in ld64">,
-     Flags<[HelpHidden]>,
-     Group<grp_undocumented>;
 def simulator_support : Flag<["-"], "simulator_support">,
      HelpText<"This option is undocumented in ld64">,
      Flags<[HelpHidden]>,

diff  --git a/lld/test/MachO/silent-ignore.test b/lld/test/MachO/silent-ignore.test
index 1038a7ec3c16..9e997d73aa97 100644
--- a/lld/test/MachO/silent-ignore.test
+++ b/lld/test/MachO/silent-ignore.test
@@ -5,6 +5,9 @@ RUN:   -no_deduplicate \
 RUN:   -lto_library /lib/foo \
 RUN:   -macosx_version_min 0 \
 RUN:   -dependency_info /path/to/dependency_info.dat \
-RUN:   -mllvm -time-passes
+RUN:   -mllvm -time-passes \
+RUN:   -objc_abi_version 2 \
+RUN:   -ios_simulator_version_min 9.0.0 \
+RUN:   -sdk_version 13.2
 RUN: not %lld -v --not-an-ignored-argument 2>&1 | FileCheck %s
 CHECK: error: unknown argument: --not-an-ignored-argument