[PATCH] D88288: [Archive] Don't throw away errors for malformed archive members

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 11:27:57 PDT 2020


MaskRay added a comment.

Checked lld/test/ELF updates, GNU ar silently allows invalid 'symbolic' files. I think being more rigid in llvm-ar is fine.

An alternative to the new `isSymbolicFile` is by checking whether `createSymbolicFile` returns an ECError whose error_code is `object_error::invalid_file_type`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88288/new/

https://reviews.llvm.org/D88288



More information about the llvm-commits mailing list