[PATCH] D88246: [AMDGPU] Add bfi immediate pattern

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 10:56:51 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:1564
+  }]
+>;
+
----------------
foad wrote:
> arsenm wrote:
> > GlobalISel predicate?
> I could add a GISelPredicateCode but whatever I put in there won't even get compiled, let alone tested, until some of these patters actually get used by globalisel. So I'd prefer to leave it all to another patch.
OK, I thought this was the main barrier


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88246/new/

https://reviews.llvm.org/D88246



More information about the llvm-commits mailing list