[PATCH] D88309: [LTO][Legacy] Add API to set result type to assembly

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

In D88309#2295281 <https://reviews.llvm.org/D88309#2295281>, @hubert.reinterpretcast wrote:

> In D88309#2295142 <https://reviews.llvm.org/D88309#2295142>, @steven_wu wrote:
>
>> - If this is just a temporary workaround, I would resist make this change to bake in this API that will not be used in the future.
>
> This seems to be conflating the immediate reason with the more general value of having such an interface. The interface that @tejohnson's earlier comment mentions presumably exists because there is value in having such an interface.

C++ interface is different from a libLTO C API which has additional requirement for compatibility. You can use the new C++ interface mentioned by @tejohnson or use the underlying c++ API for legacy API `CG->setFileType()` if you want.
I am fine with adding such a C API but I want to make sure you think through all the options, not just adding a new stable C API that is going to be thrown away.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88309/new/

https://reviews.llvm.org/D88309