[PATCH] D88308: [unittests] Preserve LD_LIBRARY_PATH in crash recovery test
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 25 08:40:20 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/unittests/Support/CrashRecoveryTest.cpp:185
bool ExecutionFailed;
int RetCode = ExecuteAndWait(Executable, argv, makeArrayRef(EnvTable), {}, 0, 0, &Error,
&ExecutionFailed);
----------------
Perhaps ExecuteAndWait should have a mode to append environment variables. In the absence of that feature,
llvm/utils/not/not.cpp
```
#ifdef _WIN32
SetEnvironmentVariableA("...);
#else
setenv(...);
#endif
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88308/new/
https://reviews.llvm.org/D88308
More information about the llvm-commits
mailing list