[PATCH] D88288: [Archive] Don't throw away errors for malformed archive members
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 25 08:16:16 PDT 2020
grimar added a comment.
Minor nit. Otherwise looks good to me. Lets see what others think.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:363
+
+ file_magic Type = identify_magic(Buf.getBuffer());
+ // Treat unsupported file types as having no symbols.
----------------
I'd use `const`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88288/new/
https://reviews.llvm.org/D88288
More information about the llvm-commits
mailing list