[PATCH] D74169: [WIP][LLD][ELF][DebugInfo] Remove obsolete debug info.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: lld/ELF/LLDDwarfLinker.cpp:80
+          SymbolAddresses addr = getSymbolAddresses(symbol, sec);
+          addressRanges[{addr.objectAddress, secToIndex[sec]}] = {
+              addr.objectAddress + symbol->getSize(),
----------------
The RangesTy is defined as a map with uint64_t
using RangesTy = std::map<uint64_t, ObjFileAddressRange>;

Not sure I follow how this works. Am I missing some c++ thing? This fails to compile with clang.


================
Comment at: lld/ELF/LLDDwarfLinker.cpp:222
+  debugInfoLinker.setAccelTableKind(config->debugNames ? AccelTableKind::Dwarf
+                                                       : AccelTableKind::None);
+  debugInfoLinker.setErrorHandler(ReportWarn);
----------------
There is no AccelTableKind::None, did you mean AccelTableKind::Default?

enum class AccelTableKind {
  Apple,   ///< .apple_names, .apple_namespaces, .apple_types, .apple_objc.
  Dwarf,   ///< DWARF v5 .debug_names.
  Default, ///< Dwarf for DWARF5 or later, Apple otherwise.
};


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74169/new/

https://reviews.llvm.org/D74169