[PATCH] D88279: SAVE statement should not apply to nested scoping units

[Tim Keith via Phabricator via llvm-commits]

tskeith added a subscriber: klausler.
tskeith added inline comments.


================
Comment at: flang/lib/Evaluate/tools.cpp:1008
+    } else if (scope->hasSAVE() ) {
+      return true;
     }
----------------
It's not clear to me why the call to `hasSAVE` is necessary at all. In resolve-names.cpp we set the SAVE attribute on the appropriate entities when a SAVE statement is encountered. So the symbol should have the SAVE attribute set here if SAVE is set in the scope.

I think you can remove the call to `hasSAVE` completely. And since it's the only call, remove the function and related stuff.

@klausler, do you know of any reason we need `hasSAVE`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88279/new/

https://reviews.llvm.org/D88279