[PATCH] D88033: [SVE][CodeGen] Legalisation of integer -> floating point conversions
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 25 06:24:05 PDT 2020
paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
LGTM assuming the potential compiler warning is removed.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9081-9083
+ EVT VT = Op.getValueType();
+ assert(VT.isScalableVector() && isTypeLegal(VT) &&
+ "Expected legal scalable vector type!");
----------------
I'm pretty sure this will cause an "unused variable - VT" compile time warning when building without asserts and thus will need to be verbose (i.e. `assert(Op.getValueType().isScalable() && ...`)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88033/new/
https://reviews.llvm.org/D88033
More information about the llvm-commits
mailing list