[compiler-rt] 7af1201 - [msan] Remove redundant test

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 02:40:03 PDT 2020


Author: Vitaly Buka
Date: 2020-09-25T02:36:59-07:00
New Revision: 7af12015ad44bccb23bd61820c8f34212467e71c

URL: https://github.com/llvm/llvm-project/commit/7af12015ad44bccb23bd61820c8f34212467e71c
DIFF: https://github.com/llvm/llvm-project/commit/7af12015ad44bccb23bd61820c8f34212467e71c.diff

LOG: [msan] Remove redundant test

The test needs to control intercept_strcmp option.
It's already implemented as lit.test strcmp.c.

Added: 
    

Modified: 
    compiler-rt/lib/msan/tests/msan_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/msan/tests/msan_test.cpp b/compiler-rt/lib/msan/tests/msan_test.cpp
index 318a355312a5..1ece56e66571 100644
--- a/compiler-rt/lib/msan/tests/msan_test.cpp
+++ b/compiler-rt/lib/msan/tests/msan_test.cpp
@@ -587,20 +587,6 @@ LargeStruct LargeRetTest() {
   return res;
 }
 
-TEST(MemorySanitizer, strcmp) {
-  char s1[10];
-  char s2[10];
-  strncpy(s1, "foo", 10);
-  s2[0] = 'f';
-  s2[1] = 'n';
-  EXPECT_GT(strcmp(s1, s2), 0);
-  s2[1] = 'o';
-  int res;
-  EXPECT_UMR(res = strcmp(s1, s2));
-  EXPECT_NOT_POISONED(res);
-  EXPECT_EQ(strncmp(s1, s2, 1), 0);
-}
-
 TEST(MemorySanitizer, LargeRet) {
   LargeStruct a = LargeRetTest();
   EXPECT_POISONED(a.x[0]);


        


More information about the llvm-commits mailing list