[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

[Ankit via Phabricator via llvm-commits]

quic_aankit added a comment.

In D88138#2294257 <https://reviews.llvm.org/D88138#2294257>, @aeubanks wrote:

> I think I'm still missing how exactly this will fit into the pipeline. As in where is `registerPassBuilderCallbacks()` going to be called?
>
> And a test like llvm/test/CodeGen/AMDGPU/opt-pipeline.ll for the new pass manager route would be nice to make sure this actually works.
> something like `RUN: opt -passes='default<O0>' -mtriple=... -disable-output -disable-verify -debug-pass-manager`. Maybe checking all the normal passes isn't necessary like in the existing opt-pipeline.ll isn't necessary, just need to check that the custom passes (e.g. `HexagonVectorLoopCarriedReusePass`) are actually added.

My understanding is that this API gives other applications chance to modify the pass pipeline. HexagonVectorLoopCarriedReuse pass in not included in the pass pipeline for any optimization level, but we used to add the pass using adjustPassManager in Halide. That is why I don't think I can use the suggested method to test if the pass is being added


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88138/new/

https://reviews.llvm.org/D88138